[PATCH] D139752: cmake: Enable 64bit off_t on 32bit glibc systems

[Steven Johnson via Phabricator via llvm-commits]

srj added a comment.

In D139752#4045548 <https://reviews.llvm.org/D139752#4045548>, @MaskRay wrote:

> @srj Will you be able to help figure out the 32-bit Halide issue? Thanks in advance:)

Yes, I can take a look; what is the current status of this -- is there an updated patch or should I just reapply this?



================
Comment at: llvm/cmake/config-ix.cmake:342
+  if (CMAKE_SIZEOF_VOID_P EQUAL 4)
+    add_definitions( -D_FILE_OFFSET_BITS=64 )
+    list(APPEND CMAKE_REQUIRED_DEFINITIONS "-D_FILE_OFFSET_BITS=64")
----------------
alexreinking wrote:
> I believe the problem @srj encountered is caused by this line. The `add_definitions` command is bug-prone and was superseded by `add_compile_definitions` (correctly used a few lines up) in CMake 3.12.
I tried replacing that line with `add_compile_definitions(_FILE_OFFSET_BITS=64)` and I still fail locally in exactly the same way.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139752/new/

https://reviews.llvm.org/D139752