[PATCH] D137615: [BOLT][Instrumentation] Instrument leaves from spanning tree

[Rafael Auler via Phabricator via llvm-commits]

rafauler added a comment.

Hi @yavtuk! Thanks for the patch.

I was on leave and couldn't get to it earlier, sorry about that.

> And it means that we insert an instrumentation snippet to all BBs that originally filtered when constructing the spanning tree.

Here, what do you mean by BBs originally filtered? I might be missing something, so I'll tell you what I know about this code and you correct me if I'm wrong. It is true that this code currently inserts an empty std::set for elements not in STOutSet and triggers the condition that instruments this basic block. So any blocks not in STOutSet will be instrumented. But this is by design, the idea being that we may only omit instrumentation in specific cases, when the node is part of the spanning tree and not a leaf. In these cases, the node will be in STOutSet and we will skip adding instrumentation code to it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137615/new/

https://reviews.llvm.org/D137615