[PATCH] D140988: [SystemZ] Implement lowering of GET_ROUNDING

Ulrich Weigand via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 11 13:22:03 PST 2023


uweigand accepted this revision.
uweigand added a subscriber: jonpa.
uweigand added a comment.
This revision is now accepted and ready to land.

  ; CHECK-NEXT:    efpc %r0
  ; CHECK-NEXT:    lr %r1, %r0
  ; CHECK-NEXT:    nilf %r1, 3
  ; CHECK-NEXT:    rxsbg %r1, %r0, 63, 63, 63
  ; CHECK-NEXT:    xilf %r1, 1

Huh.  We still get the `lr` :-(   That now seems an inefficiency in the RXSBG optimization pass, so it's not a problem with this patch, which now LGTM.   Thanks again!

@jonpa maybe you can have a look into why it doesn't simply use the same register as source and destination of the RXSGB?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140988/new/

https://reviews.llvm.org/D140988



More information about the llvm-commits mailing list