[PATCH] D140790: [MachineBasicBlock] Explicit FT branching param

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 11 11:51:24 PST 2023


arsenm added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/MachineBasicBlock.h:780
+  /// set AllowExplicitFT to be false. Non-null return is a conservative answer.
+  MachineBasicBlock *getFallThrough(bool AllowExplicitFT = true);
 
----------------
gandhi21299 wrote:
> arsenm wrote:
> > ExplicitFT isn't the right name. It's an unconditional branch. Introduce another name, maybe getFallthroughOrUnconditionalSuccessor?
> Sorry, do you mean for the method name or the parameter?
Separate method name, the parameter also should be something else if you leave it here as an implementation detail


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140790/new/

https://reviews.llvm.org/D140790



More information about the llvm-commits mailing list