[PATCH] D140368: [lldb] Consider all breakpoints in breakpoint detection

[Jim Ingham via Phabricator via llvm-commits]

jingham accepted this revision.
jingham added a comment.
This revision is now accepted and ready to land.

LGTM, thanks for figuring this out!



================
Comment at: lldb/source/Target/StopInfo.cpp:540
 
+            if (m_should_stop && !bp_loc_sp->GetBreakpoint().IsInternal())
+              internal_breakpoint = false;
----------------
DavidSpickett wrote:
> I think the key here is the `m_should_stop` check (the rest looks equivalent to what is there already). What exactly does that achieve?
The point is that once we've looked at all the locations that were in the site we stopped at, if all the breakpoints that said we should stop here were internal, then we must be implementing a thread plan and we should give the thread plan a chance to set the stop info.  But if there were any non-internal breakpoints that say we should stop, then we should report the breakpoint stop reason instead.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140368/new/

https://reviews.llvm.org/D140368