[PATCH] D135488: [codegen] Add a remarks based Stack Layout Analysis pass

Francis Visoiu Mistrih via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 11 10:58:06 PST 2023


thegameg added a comment.

In D135488#4044437 <https://reviews.llvm.org/D135488#4044437>, @paulkirth wrote:

> BTW, is there a way to nest some of the items? Ideally we'd be able to have a `Slot` in the YAML that contains all the various data, similar to how `DebugLoc` is a more complex object with fields for `File`, `Line`, and `Column`. That way we could group all the data for each slot including variable locations.
>
> I know how that would look in YAML, but I'm unaware of how we'd do that with the existing remarks interfaces... or if doing so would massively change the CLI output. any pointers here?

Unfortunately no, there is no easy way to do that right now, but I agree it would be nice. The `Args` seem easy enough to process that I wouldn't bother trying to group them. `optrecord.py` (and libRemarks) will handle it in the right order so the users can easily work with it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135488/new/

https://reviews.llvm.org/D135488



More information about the llvm-commits mailing list