[PATCH] D140693: [Driver][RISCV] Adjust the priority between -mcpu, -mtune and -march

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: clang/docs/ReleaseNotes.rst:792
 - Native detections via ``-mcpu=native`` and ``-mtune=native`` are supported.
+- Fix interaction of ``-mcpu`` and ``-march``, RISC-V back-end will take the
+  architecture extension union of ``-mcpu`` and ``-march`` before, and now will
----------------
back-end -> backend


================
Comment at: clang/lib/Driver/ToolChains/Arch/RISCV.cpp:47
+      Features, [&Args](const Twine &Str) { return Args.MakeArgString(Str); },
+      true);
   return true;
----------------
`true` -> `/*AddAllExtensions*/true`


================
Comment at: llvm/lib/Support/RISCVISAInfo.cpp:14
 #include "llvm/ADT/StringRef.h"
+#include "llvm/ADT/StringSet.h"
 #include "llvm/Support/Errc.h"
----------------
Why is this needed?


================
Comment at: llvm/lib/Support/RISCVISAInfo.cpp:335
+                              std::function<StringRef(const Twine &)> StrAlloc,
+                              bool AddAllExtension) const {
   for (auto const &Ext : Exts) {
----------------
AddAllExtension -> AddAllExtensions


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140693/new/

https://reviews.llvm.org/D140693