[PATCH] D141513: [ARM][AArch64] Switch to generic MEMBARRIER node

[Philip Reames via Phabricator via llvm-commits]

reames created this revision.
reames added reviewers: lenary, greened, david-arm, paulwalker-arm.
Herald added subscribers: bollu, hiraditya, kristof.beyls, mcrosier.
Herald added a project: All.
reames requested review of this revision.
Herald added a project: LLVM.

This change switches both targets from using target specific CompilerBarrier nodes to the recently introduced generic MEMBARRIER instruction.

A couple things to call out.

First, this changes the assembly comment printed.  I'm not sure this matters, but if it does, we can simply drop this patch.  This is a minor clean up at best.

Second, the ordering operand on the target instruction appears to be unused.  We could easily add ordering to the generic instruction, but since we don't seem to have a motivating case in tree, I simply dropped the ordering when selecting to the generic instruction.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D141513

Files:
  llvm/lib/Target/AArch64/AArch64InstrAtomics.td
  llvm/lib/Target/AArch64/GISel/AArch64InstructionSelector.cpp
  llvm/lib/Target/AArch64/MCTargetDesc/AArch64InstPrinter.cpp
  llvm/lib/Target/AArch64/MCTargetDesc/AArch64MCCodeEmitter.cpp
  llvm/lib/Target/ARM/ARMInstrInfo.td
  llvm/lib/Target/ARM/ARMScheduleA57.td
  llvm/test/CodeGen/AArch64/fence-singlethread.ll
  llvm/test/CodeGen/ARM/fence-singlethread.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D141513.488239.patch
Type: text/x-patch
Size: 5043 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230111/0f4ac380/attachment.bin>