[PATCH] D139097: [ARM] Add option --print-raw-value to llvm-nm to dump raw symbol values in case of ARM

Subham Kedia via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 11 08:18:38 PST 2023


quic-subhkedi marked an inline comment as done.
quic-subhkedi added inline comments.


================
Comment at: llvm/include/llvm/Object/ELFObjectFile.h:617
+    return SymOrErr.takeError();
+  Result = (*SymOrErr)->st_value;
+
----------------
apazos wrote:
> Result setting here overwrites the value set above under the flags checks. This code does not look correct.
added the else blocks to preserve the result values


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139097/new/

https://reviews.llvm.org/D139097



More information about the llvm-commits mailing list