[PATCH] D141272: [lld][ARM] support position independent thunks for Armv4(T)

Wed Jan 11 07:42:33 PST 2023

peter.smith accepted this revision.
peter.smith added a comment.
This revision is now accepted and ready to land.

I'm happy with these from the Arm v4 support perspective. I think some TODO comments may no longer apply, but these can easily be fixed up pre-commit.

================
Comment at: lld/ELF/Thunks.cpp:1239
 //
 // TODO: Support PIC interworking thunks for V4T.
 // TODO: More efficient PIC non-interworking thunks for V4T.
----------------
Are these TODOs still applicable? If not then they can be removed.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141272/new/

https://reviews.llvm.org/D141272