[PATCH] D140699: [OptTable] Make ValuesCode initialisation of Options constexpr

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 11 07:28:39 PST 2023


nikic added inline comments.


================
Comment at: llvm/utils/TableGen/OptParserEmitter.cpp:268
+    if (!isa<UnsetInit>(R.getValueInit("ValuesCode"))) {
+      assert(!isa<UnsetInit>(R.getValueInit("Values")) &&
+           "Cannot choose between Values and ValuesCode");
----------------
Isn't this assert the wrong way around?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140699/new/

https://reviews.llvm.org/D140699



More information about the llvm-commits mailing list