[PATCH] D138814: [InstCombine] Combine lshr of add -> (a + b < a)
Pierre van Houtryve via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jan 11 03:53:01 PST 2023
Pierre-vh marked 2 inline comments as done.
Pierre-vh added inline comments.
================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineShifts.cpp:848
+// - The add is only used by the shr, or by iK (or narrower) truncates.
+// - The lshr type has more than 2 bits (other types are boolean math).
+// - K > 1
----------------
foad wrote:
> Likewise I don't think you need this line and the "boolean math" comment belongs on the "K > 1" line.
Will address in D141129
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D138814/new/
https://reviews.llvm.org/D138814
More information about the llvm-commits
mailing list