[PATCH] D141372: MachineIRBuilder: Rename buildMerge. NFC
Jay Foad via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jan 11 01:05:21 PST 2023
foad added a comment.
In D141372#4040553 <https://reviews.llvm.org/D141372#4040553>, @scott.linder wrote:
> Tiny driveby bikeshed (feel free to ignore): `buildMergeLikeInstr`? It is longer, but `Op` seems to more commonly mean "Operand" here (save for some stuff like `buildAssertOp`).
I'm not a huge fan of the "Op" part either, but there is a precedent for it in the GMergeLikeOp wrapper class.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D141372/new/
https://reviews.llvm.org/D141372
More information about the llvm-commits
mailing list