[PATCH] D141268: [ELF] Emit Verbose Asm when using --lto-emit-asm

[Pierre van Houtryve via Phabricator via llvm-commits]

Pierre-vh added inline comments.


================
Comment at: lld/test/ELF/lto/emit-asm.ll:16
+
+; CHECK-DAG: # -- Begin function f1
 ; CHECK-DAG: f1:
----------------
MaskRay wrote:
> You can drop `-DAG` for all CHECK lines. I don't think they make tests more maintainable.
There's `cat %t2.s %t2.s1 | FileCheck %s` above f2 comes before f1 for that one (f2 is in `%t2.s`), so if I remove -DAG the test fails.
I'm not sure how `lto-partitions=2` works. Is f2 always in `%t2.s` and f1 always in `%t2.s1`? If yes I think we can swap the arguments to `cat` & remove -DAG


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141268/new/

https://reviews.llvm.org/D141268