[PATCH] D141279: [DebugInfo][CSInfo] Avoid using clobbered registers as call-site argument locations

[Djordje Todorovic via Phabricator via llvm-commits]

djtodoro added a comment.

Looks reasonable to me.

> In terms of call-site coverage, I've built stage2 RelWithDebInfo clang with and without this patch, based on rG2b1d45b227bd <https://reviews.llvm.org/rG2b1d45b227bdbb1f59934905a5204d16ea0d378b>, and there are roughly 5% fewer DW_AT_call_value attributes produced once this patch is applied, which I think we can reasonably conclude were incorrect locations.

The number refers to x86 target, right?



================
Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp:704
   // registers, add those defines.
+  SmallSet<Register, 16> NewClobberedRegUnits;
   auto getForwardingRegsDefinedByMI = [&](const MachineInstr &MI,
----------------
nit: Can we make a type alias for the small set?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141279/new/

https://reviews.llvm.org/D141279