[PATCH] D139553: [llvm-objdump][RISCV] Use new common method to parse ARCH RISCV attribute

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 10 20:23:35 PST 2023


MaskRay added inline comments.


================
Comment at: llvm/test/tools/llvm-objdump/ELF/RISCV/objdump.s:1
+# RUN: llvm-mc -filetype=obj -triple riscv64 < %s | \
+# RUN:     llvm-objdump -d -M no-aliases - | \
----------------
MaskRay wrote:
> drop `< ` for llvm-mc
`objdump.s` is not a good name. Add a file-level comment what this test is about.

If you want to test that llvm-objdump by default decodes most instructions, add a few more instructions beside `vsetvli` (one instruction doesn't tell much).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139553/new/

https://reviews.llvm.org/D139553



More information about the llvm-commits mailing list