[PATCH] D141268: [LLD] Emit Verbose Asm when using `lto-emit-asm`

Tue Jan 10 18:16:45 PST 2023

MaskRay added a comment.

`[ELF] ` tag is more common for lld/ELF changes. `lto-emit-asm` => `--lto-emit-asm` (drop quotes in the subject).

================
Comment at: lld/test/ELF/lto/emit-asm.ll:14

+; Note: we also check for the presence of comments; lto-emit-asm output should be verbose.
+
----------------

================
Comment at: lld/test/ELF/lto/emit-asm.ll:16
+
+; CHECK-DAG: # -- Begin function f1
 ; CHECK-DAG: f1:
----------------
You can drop `-DAG` for all CHECK lines. I don't think they make tests more maintainable.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141268/new/

https://reviews.llvm.org/D141268