[PATCH] D141223: AMDGPU: Remove IsSourceOfDivergence check
Ruiling, Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jan 10 18:00:32 PST 2023
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGcce24b6af099: AMDGPU: Remove IsSourceOfDivergence check (authored by ruiling).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D141223/new/
https://reviews.llvm.org/D141223
Files:
llvm/lib/Target/AMDGPU/SIDefines.h
llvm/lib/Target/AMDGPU/SIInstrInfo.cpp
Index: llvm/lib/Target/AMDGPU/SIInstrInfo.cpp
===================================================================
--- llvm/lib/Target/AMDGPU/SIInstrInfo.cpp
+++ llvm/lib/Target/AMDGPU/SIInstrInfo.cpp
@@ -8404,9 +8404,6 @@
InstructionUniformity
SIInstrInfo::getInstructionUniformity(const MachineInstr &MI) const {
- if (MI.getDesc().TSFlags & SIInstrFlags::IsSourceOfDivergence)
- return InstructionUniformity::NeverUniform;
-
// Atomics are divergent because they are executed sequentially: when an
// atomic operation refers to the same address in each thread, then each
// thread after the first sees the value written by the previous thread as
Index: llvm/lib/Target/AMDGPU/SIDefines.h
===================================================================
--- llvm/lib/Target/AMDGPU/SIDefines.h
+++ llvm/lib/Target/AMDGPU/SIDefines.h
@@ -130,13 +130,6 @@
// Is a WMMA instruction.
IsWMMA = UINT64_C(1) << 59,
-
- // Is source of divergence.
- //
- // Note: There is no corresponding SIInstrInfo::IsSourceOfDivergence method
- // by design, since this flag only covers opcodes that are _always_ divergent.
- // Use SIInstrInfo::getInstructionUniformity for a more complete analysis.
- IsSourceOfDivergence = UINT64_C(1) << 60
};
// v_cmp_class_* etc. use a 10-bit mask for what operation is checked.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D141223.488047.patch
Type: text/x-patch
Size: 1336 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230111/b014961f/attachment.bin>
More information about the llvm-commits
mailing list