[PATCH] D141444: [GCOV] Set !kcfi_type metadata for indirectly called functions

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

Ensuring that every instrumentation works with kcfi is a lot of work on the compiler side (think that another instrumentation technique comes up, we need to update O(n) existing instrumentation passes) and I don't quite agree that it's compiler's responsibility.
But if sanitizers and gcov are all, I think it's fine...



================
Comment at: llvm/include/llvm/Transforms/Utils/ModuleUtils.h:45
 
+/// Sets the KCFI type for the function. Use for compiler-generated functions
+/// that are indirectly called in instrumented code.
----------------
Used


================
Comment at: llvm/test/Transforms/GCOVProfiling/kcfi.ll:25
+
+;; Ensure __llvm_gcov_(writeout|reset|init) have !kcfi_type with KCFI.
+; CHECK: define internal void @__llvm_gcov_writeout()
----------------
This comment should be moved to the top.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141444/new/

https://reviews.llvm.org/D141444