[PATCH] D140909: llvm-reduce: Fix assertion on blockaddress during function reduction
Arthur Eubanks via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jan 10 16:06:31 PST 2023
aeubanks accepted this revision.
aeubanks added inline comments.
This revision is now accepted and ready to land.
================
Comment at: llvm/test/tools/llvm-reduce/reduce-functions-blockaddress-wrong-function.ll:6-7
+; function has blockaddress references. When the second function is
+; deleted, it causes the blockreferences from the first to be replaced
+; with inttoptr.
+
----------------
very weird, no idea why this would be happening. perhaps some cloning issue?
================
Comment at: llvm/tools/llvm-reduce/deltas/ReduceFunctions.cpp:36
+
+ // TODO: Could handle aliases and blockaddresses, we just need to replace
+ // those users.
----------------
not sure I agree with this TODO
we should let the alias pass handle aliases and the instruction/globals pass handle blockaddresses, and keep this one simple
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D140909/new/
https://reviews.llvm.org/D140909
More information about the llvm-commits
mailing list