[PATCH] D141367: [SchedBoundary] Add dump method for resource usage.

[Jon Roelofs via Phabricator via llvm-commits]

jroelofs accepted this revision.
jroelofs added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/include/llvm/CodeGen/MachineScheduler.h:694
+  /// In this case, the total number of resource instances is 6. The
+  /// vector \ref ReservedCycles will have a slow for each instance. The
+  /// vector \ref ReservedCyclesIndex will track at what index the first
----------------
s/slow/slot/ ?


================
Comment at: llvm/lib/CodeGen/MachineScheduler.cpp:2600
+LLVM_DUMP_METHOD void SchedBoundary::dumpReservedCycles() const {
+  if (SchedModel->hasInstrSchedModel()) {
+
----------------
invert + early return?


================
Comment at: llvm/test/CodeGen/AArch64/dump-reserved-cycles.mir:6
+# RUN: -run-pass=machine-scheduler -debug-only=machine-scheduler -o - %s 2>&1 | FileCheck %s --check-prefix=NODUMP
+
+# REQUIRES: asserts
----------------
Probably a good idea to explicitly specify the mcpu so it's resilient to the possibility of the default changing out from under it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141367/new/

https://reviews.llvm.org/D141367