[PATCH] D141412: [InstCombine]: Add tests for icmp ne non-zero power of 2; NFC

[Noah Goldstein via Phabricator via llvm-commits]

goldstein.w.n marked an inline comment as done.
goldstein.w.n added inline comments.


================
Comment at: llvm/test/Transforms/InstCombine/icmp-ne-pow2.ll:332
+  %ygt = icmp ugt i32 %y, %x
+  call void @llvm.assume(i1 %ygt)
+
----------------
nikic wrote:
> goldstein.w.n wrote:
> > nikic wrote:
> > > Not sure I understand the significance of this test. It seems like the same as the previous with this extra assume, but why is it relevant?
> > > Not sure I understand the significance of this test. It seems like the same as the previous with this extra assume, but why is it relevant?
> > 
> > ```
> > if (Pow2(Y) && Y > X)
> >    X & Y -> 0
> > ```
> > 
> In that case, shouldn't the assume below this be dropped? Otherwise that's a contradiction.
> In that case, shouldn't the assume below this be dropped? Otherwise that's a contradiction.

You're right, done in V3. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141412/new/

https://reviews.llvm.org/D141412