[PATCH] D133392: [MTE] Add AArch64GlobalsTagging Pass

[Evgenii Stepanov via Phabricator via llvm-commits]

eugenis accepted this revision.
eugenis added a comment.

LGTM



================
Comment at: llvm/lib/CodeGen/GlobalMerge.cpp:655
 
+    // Don't merged tagged globals, as each global should have its own unique
+    // memory tag at runtime. TODO(hctim): This can be relaxed: constant globals
----------------
typo: "merge"


================
Comment at: llvm/lib/Target/AArch64/AArch64GlobalsTagging.cpp:75
+  if (SizeInBytes != NewSize) {
+    DataLayout NewLayout = M.getDataLayout();
+
----------------
unused variable


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133392/new/

https://reviews.llvm.org/D133392