[PATCH] D140988: [SystemZ] Implement lowering of GET_ROUNDING

[Nikita Popov via Phabricator via llvm-commits]

nikic added inline comments.


================
Comment at: llvm/lib/Target/SystemZ/SystemZISelLowering.cpp:9083
+      DAG.getNode((VT.getSizeInBits() < 32 ? ISD::TRUNCATE : ISD::ZERO_EXTEND),
+                  dl, VT, RetVal);
+
----------------
nit: There is a `DAG.getZExtOrTrunc()` helper.


================
Comment at: llvm/test/CodeGen/SystemZ/flt-rounds.ll:23
+
+define dso_local signext i32 @test_order(i32 noundef signext %0) {
+; CHECK-LABEL: test_order:
----------------
nit: You can add `nounwind` to avoid irrelevant cfi directives.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140988/new/

https://reviews.llvm.org/D140988