[PATCH] D141408: [CodeGen] Introduce a generic MEMBARRIER instruction [mostly-nfc]

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp:2903
+  case ISD::MEMBARRIER:
+    // TODO: Factor out routine - and generalize op types?
+    // @Reviewers - Surely there's a pattern mechanism for this?
----------------
I don't know of any target independent isel patterns today. I think all of the target independent opcodes are handled in this switch. The ones that do `setNodeId(-1)` are converted to MachineInstr in InstrEmitter.cpp.

Not sure what the "generalize op types" part of this comment means.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141408/new/

https://reviews.llvm.org/D141408