[PATCH] D141369: [mlir][SparseTensor] Add a few more tests for sparse vectorization

[wren romano via Phabricator via llvm-commits]

wrengr added a comment.

Could you reformat the CHECK blocks so they don't have so much leading whitespace between the CHECK and the code?



================
Comment at: mlir/test/Dialect/SparseTensor/vectorize_reduction.mlir:490
+// CHECK-OFF:         }
+#SparseVector = #sparse_tensor.encoding<{dimLevelType = ["compressed"]}>
+
----------------
I'd add a newline before this, to separate it from the CHECK stuff. (Usually we don't have a blank line, but then usually we have the `func.func` op immediately after its corresponding CHECK stuff.)


================
Comment at: mlir/test/Dialect/SparseTensor/vectorize_reduction.mlir:563
+// CHECK-OFF:         }
+#SparseVector = #sparse_tensor.encoding<{dimLevelType = ["compressed"]}>
+
----------------
ditto. (And ditto for the other tests to follow)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141369/new/

https://reviews.llvm.org/D141369