[PATCH] D139097: [ARM] Add option --print-raw-value to llvm-nm to dump raw symbol values in case of ARM

Ana Pazos via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 10 10:56:58 PST 2023


apazos added inline comments.


================
Comment at: llvm/include/llvm/Object/ELFObjectFile.h:617
+    return SymOrErr.takeError();
+  Result = (*SymOrErr)->st_value;
+
----------------
Result setting here overwrites the value set above under the flags checks. This code does not look correct.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139097/new/

https://reviews.llvm.org/D139097



More information about the llvm-commits mailing list