[PATCH] D140560: AMDGPU: Fix broken opaque pointer handling in printf pass

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 10 10:45:57 PST 2023


arsenm added a comment.

In D140560#4040714 <https://reviews.llvm.org/D140560#4040714>, @nemanjai wrote:

> In D140560#4040448 <https://reviews.llvm.org/D140560#4040448>, @arsenm wrote:
>
>>> @arsenm Would a fix similar to this be acceptable?
>>
>> Yes, I was hoping to extend this to up to 16-bytes at a time but I guess I can figure that out then (we should probably just be emitting a memcpy/strcpy anyway)
>
> Did you want me to go ahead with this fix now to unblock the bots and then you guys can finalize the fixes with `memcpy/strcpy` at a later date?

Yes, thanks


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140560/new/

https://reviews.llvm.org/D140560



More information about the llvm-commits mailing list