[PATCH] D141327: [llvm][ADT] Add deduction guides for `MutableArrayRef`

[Joe Loser via Phabricator via llvm-commits]

jloser added a comment.

In D141327#4040331 <https://reviews.llvm.org/D141327#4040331>, @dblaikie wrote:

> I'd be OK with the testing just being the static_asserts without the rest of the testing (since that's all the deduction guide do - specifies what type to use, then the usual ctor rules kick in - and those ctors are already tested elsewhere) - but this is OK too, if you prefer it.

I slightly prefer it actually (and it's what we do in `libc++` too — both compile-time and runtime tests for testing deduction guides).  Here, we plan on eventually removing `makeMutableArrayRef` (which tests runtime behavior above).  When we remove those function templates and their tests, it'd be good to preserve similar behavior in my mind.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141327/new/

https://reviews.llvm.org/D141327