[PATCH] D140985: [IR] Support importing modules with invalid data layouts.
Matt Arsenault via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jan 10 09:52:02 PST 2023
arsenm added a comment.
In D140985#4028694 <https://reviews.llvm.org/D140985#4028694>, @jsilvanus wrote:
> In D140985#4028591 <https://reviews.llvm.org/D140985#4028591>, @arsenm wrote:
>
>> Is DataLayout compatibility still determined with string equality and not semantic equality?
>
> What exactly do you mean?
> The callback mechanism changed in this patch was and is string-based, and the parsing of the string into a DL happens after the callback.
I mean llvm-link complains if you link modules with different datalayouts, but it does dumb string comparison so if you reorder fields (or rely on defaulted fields) it prints a warning
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D140985/new/
https://reviews.llvm.org/D140985
More information about the llvm-commits
mailing list