[PATCH] D141397: [AArch64][SVE]: Optimize using ptest with whilelo

Tue Jan 10 09:16:13 PST 2023

david-arm added inline comments.

================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:266
       return false;
+    case Intrinsic::aarch64_sve_whilelo:
     case Intrinsic::aarch64_sve_ptrue:
----------------
Hi @hassnaa-arm, I think we should probably add the other while variants too here, since the same thing applies for whilelt, etc.

================
Comment at: llvm/test/CodeGen/AArch64/sve2-ptest_whilelt.ll:1
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
+; RUN: llc  < %s | FileCheck %s
----------------
The test file suggests this is SVE2, but in fact whilelo was introduced in SVE. Also, the file name suggests you're testing whilelt, but actually it's testing whilelo. Is it worth just renaming the file to be something like

  sve-ptest-removal-while.ll

similar to the other existing sve-ptest-removal-xyz.ll tests?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141397/new/

https://reviews.llvm.org/D141397