[PATCH] D127115: [RFC][DAGCombine] Make sure combined nodes are added back to the worklist in topological order.

Krzysztof Parzyszek via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 10 09:10:30 PST 2023


kparzysz added inline comments.


================
Comment at: llvm/test/CodeGen/Hexagon/autohvx/isel-vpackew.ll:8
 ; CHECK-NEXT:    {
-; CHECK-NEXT:     r7 = #-4
+; CHECK-NEXT:     r7 = #124
 ; CHECK-NEXT:     v0 = vmem(r0+#0)
----------------
This is fine.


================
Comment at: llvm/test/CodeGen/Hexagon/autohvx/mulh.ll:19
+; V60-NEXT:    {
+; V60-NEXT:     v0.h = vpacko(v1.w,v0.w)
 ; V60-NEXT:    }
----------------
deadalnix wrote:
> How do we get some Hexagon expert to look at this? @MaskRay ? @kparzysz ?
This isn't good.  I'll take a look.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127115/new/

https://reviews.llvm.org/D127115



More information about the llvm-commits mailing list