[PATCH] D141392: Avoid u8"" literals in tests, their type changes in C++20

Ilya Biryukov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 10 08:22:11 PST 2023


ilya-biryukov added a comment.

Are there any uses of `u8` string literals with `formatted_raw_ostream` outside tests? What was the effect on the final behavior here?

I just wanted to make sure we are not doing the wrong thing here. If the code used to compile and it now changes behavior, we may run into runtime failures in real code.
If that's the case, we could potentially consider adding overloads for `u8` string literals to either support it or with `=delete` to make sure the code using them will be rewritten.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141392/new/

https://reviews.llvm.org/D141392



More information about the llvm-commits mailing list