[PATCH] D141363: [DAGCombiner] Fix issue with rot chain pattern

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 10 07:09:06 PST 2023


RKSimon accepted this revision.
RKSimon added a comment.
This revision is now accepted and ready to land.

LGTM with one minor - cheers



================
Comment at: llvm/test/CodeGen/AArch64/rotate.ll:21
 
 ;; FIXME: This causes miscompile because rot combine
 ;; doesn't handle negative shift well.
----------------
;; This used to cause a miscompile because rot combine


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141363/new/

https://reviews.llvm.org/D141363



More information about the llvm-commits mailing list