[PATCH] D140599: AMDGPU: Promote array alloca if used by memmove/memcpy

[Jay Foad via Phabricator via llvm-commits]

foad added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUPromoteAlloca.cpp:611
+            Type *VecPtrTy = VectorTy->getPointerTo(Alloca->getAddressSpace());
+            Value *BitCast = Builder.CreateBitCast(Alloca, VecPtrTy);
+            Value *VecValue = Builder.CreateLoad(VectorTy, BitCast);
----------------
arsenm wrote:
> foad wrote:
> > ruiling wrote:
> > > arsenm wrote:
> > > > No reason to care about type pointers anymore
> > > Our graphics compiler has not fully switched to opaque pointers yet. @foad am I right?
> > Yes.
> Well, that needs to be fixed soon since code is going to start getting ripped out very shortly
We have top engineers working on it! https://github.com/GPUOpen-Drivers/llpc/pull/2210


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140599/new/

https://reviews.llvm.org/D140599