[PATCH] D141258: [AArch64] Fix crash for expandMOVImm

Allen zhong via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 10 05:56:45 PST 2023


Allen marked an inline comment as done.
Allen added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64ExpandImm.cpp:343
 
-  assert(BitSize == 64 && "All 32-bit immediates can be expanded with a"
+  assert(BitSize > 32 && "All 32-bit immediates can be expanded with a"
                           "MOVZ/MOVK pair");
----------------
efriedma wrote:
> This algorithm doesn't work correctly if BitSize isn't 32 or 64.  Probably the code that's creating such an immediate should be fixed.
Oh, Thanks for your confirm


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141258/new/

https://reviews.llvm.org/D141258



More information about the llvm-commits mailing list