[PATCH] D141378: [llvm] Declare llvm::makeArrayRef as obsolete

[serge via Phabricator via llvm-commits]

serge-sans-paille created this revision.
serge-sans-paille added a reviewer: mehdi_amini.
Herald added subscribers: Moerafaat, zero9178, bzcheeseman, sdasgup3, wenzhicui, wrengr, cota, teijeong, rdzhabarov, tatianashp, ThomasRaoux, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, mgester, arpith-jacob, csigg, antiagainst, shauheen, rriddle.
Herald added a reviewer: antiagainst.
Herald added a project: All.
serge-sans-paille requested review of this revision.
Herald added a reviewer: nicolasvasilache.
Herald added subscribers: llvm-commits, stephenneuendorffer, nicolasvasilache.
Herald added a reviewer: herhut.
Herald added projects: MLIR, LLVM.

Also cleans up a few remaining references.

This is the final commit for the series started by https://reviews.llvm.org/D140896


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D141378

Files:
  llvm/include/llvm/ADT/ArrayRef.h
  mlir/lib/Dialect/SPIRV/Transforms/SPIRVWebGPUTransforms.cpp
  mlir/lib/Dialect/Transform/IR/TransformInterfaces.cpp


Index: mlir/lib/Dialect/Transform/IR/TransformInterfaces.cpp
===================================================================
--- mlir/lib/Dialect/Transform/IR/TransformInterfaces.cpp
+++ mlir/lib/Dialect/Transform/IR/TransformInterfaces.cpp
@@ -394,7 +394,7 @@
   assert(paramSegments[position].data() == nullptr && "params already set");
   size_t start = this->params.size();
   llvm::append_range(this->params, params);
-  paramSegments[position] = makeArrayRef(this->params).drop_front(start);
+  paramSegments[position] = ArrayRef(this->params).drop_front(start);
 }
 
 ArrayRef<Operation *>
Index: mlir/lib/Dialect/SPIRV/Transforms/SPIRVWebGPUTransforms.cpp
===================================================================
--- mlir/lib/Dialect/SPIRV/Transforms/SPIRVWebGPUTransforms.cpp
+++ mlir/lib/Dialect/SPIRV/Transforms/SPIRVWebGPUTransforms.cpp
@@ -130,7 +130,7 @@
   Value high = combineDigits(resultDigits[2], resultDigits[3]);
 
   return rewriter.create<CompositeConstructOp>(
-      loc, mulOp->getResultTypes().front(), llvm::makeArrayRef({low, high}));
+      loc, mulOp->getResultTypes().front(), llvm::ArrayRef({low, high}));
 }
 
 //===----------------------------------------------------------------------===//
Index: llvm/include/llvm/ADT/ArrayRef.h
===================================================================
--- llvm/include/llvm/ADT/ArrayRef.h
+++ llvm/include/llvm/ADT/ArrayRef.h
@@ -491,10 +491,10 @@
   template <typename T, std::size_t N>
   ArrayRef(const std::array<T, N> &Vec) -> ArrayRef<T>;
 
-  /// Deduction guide to construct an ArrayRef from an ArrayRef (no-op) (const)
+  /// Deduction guide to construct an ArrayRef from an ArrayRef (const)
   template <typename T> ArrayRef(const ArrayRef<T> &Vec) -> ArrayRef<T>;
 
-  /// Deduction guide to construct an ArrayRef from an ArrayRef (no-op)
+  /// Deduction guide to construct an ArrayRef from an ArrayRef
   template <typename T> ArrayRef(ArrayRef<T> &Vec) -> ArrayRef<T>;
 
   /// Deduction guide to construct an ArrayRef from a C array.
@@ -569,8 +569,8 @@
 
   /// Construct an ArrayRef from a C array.
   template <typename T, size_t N>
-  ArrayRef<T> LLVM_DEPRECATED("Use deduction guide instead", "ArrayRef")
-      makeArrayRef(const T (&Arr)[N]) {
+  LLVM_DEPRECATED("Use deduction guide instead", "ArrayRef")
+  ArrayRef<T> makeArrayRef(const T (&Arr)[N]) {
     return ArrayRef<T>(Arr);
   }
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D141378.487764.patch
Type: text/x-patch
Size: 2411 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230110/238dd676/attachment-0001.bin>