[PATCH] D140498: [SLP]Fix cost of the broadcast buildvector/gather.

[Alexey Bataev via Phabricator via llvm-commits]

ABataev added inline comments.


================
Comment at: llvm/lib/Target/X86/X86TargetTransformInfo.cpp:4374
 
     // Assume pinsr/pextr XMM <-> GPR is relatively cheap on all targets.
     // Assume insertps is relatively cheap on all targets.
----------------
fhahn wrote:
> ABataev wrote:
> > fhahn wrote:
> > > Should this comment also be removed? It seems like the code has been removed?
> > No, it is not removed, the related code is all in the same lambda IsCheapPInsrPExtrInsertPS
> Ah, but it documents the logic in the helper function now, which is used in multiple places. Should it not be moved there?
> 
> Also, shouldn't the 2 sentences be merged? At the moment, the wording seems to imply that `pinsr/pextr XMM <-> GPR is relatively cheap on all targets` AND `insertps is relatively cheap on all targets.`, whereas it should be OR?
Ok, will move it to the lambda


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140498/new/

https://reviews.llvm.org/D140498