[PATCH] D141185: [MemorySSA] Don't check def set when cloning memoryaccesses

[Nikita Popov via Phabricator via llvm-commits]

nikic accepted this revision.
nikic added a comment.
This revision is now accepted and ready to land.

LG



================
Comment at: llvm/lib/Analysis/MemorySSA.cpp:1764
+    assert(Def == DefCheck ||
+           !DefCheck && "Memory accesses should only be reduced");
     if (!Def && Use != UseCheck) {
----------------
Can you please add `()` around the expression? I think it still does the right thing in the end, but mostly by accident. It will evaluate `Def == DefCheck || (!DefCheck && "")`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141185/new/

https://reviews.llvm.org/D141185