[PATCH] D141352: [ADT] Fix circular include dependency by using std::array. NFC

Younan Zhang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 9 22:25:53 PST 2023


zyounan added a comment.

Pipeline failed due to missing include header `llvm/ADT/Hashing.h`

  In file included from /var/lib/buildkite-agent/builds/llvm-project/clang-tools-extra/clangd/Config.cpp:9:
  /var/lib/buildkite-agent/builds/llvm-project/clang-tools-extra/clangd/Config.h:158:18: error: no member named 'hash_combine' in namespace 'llvm'
      return llvm::hash_combine(Val.Kind, Val.Location, Val.MountPoint);

This header was included by `ArrayRef.h` which is included by `STLExtras.h` before.

  #include "llvm/ADT/Hashing.h"

I don't think it's a good idea to dive into every TU and revise this include dependency. Let's add this to `STLExtras.h` directly.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141352/new/

https://reviews.llvm.org/D141352



More information about the llvm-commits mailing list