[PATCH] D138132: [JumpThreading] Preserve profile metadata during select unfolding

[Caroline Tice via Phabricator via llvm-commits]

cmtice added a comment.

This commit breaks the test llvm/test/Transforms/JumpThreading/select.ll if you build the compiler optimized I.e. with '-DCMAKE_BUILD_TYPE=Release'.  I tested this by building both the version just before this commit and just after this commit with -DCMAKE_BUILD_TYPE=Release, then running the test:

$  ./bin/llvm-lit -s -v ../llvm/test/Transforms/JumpThreading/select.ll

The version built just before this commit passed.:

$ ./bin/llvm-lit -s -v ../llvm/test/Transforms/JumpThreading/select.ll

Testing Time: 0.10s

  Passed: 1

The one built just after this commit failed:

$ ./bin/llvm-lit -s -v ../llvm/test/Transforms/JumpThreading/select.ll
FAIL: LLVM :: Transforms/JumpThreading/select.ll (1 of 1)

- TEST 'LLVM :: Transforms/JumpThreading/select.ll' FAILED ********************

Script:
-------

: 'RUN: at line 2';   /usr/local/google3/cmtice/new-llvm-project/build-opt/bin/opt -S -passes=jump-threading -debug-only=branch-prob < /usr/local/google3/cmtice/new-llvm-project/llvm/test/Transforms/JumpThreading/select.ll 2>&1 | /usr/local/google3/cmtice/new-llvm-project/build-opt/bin/FileCheck /usr/local/google3/cmtice/new-llvm-project/llvm/test/Transforms/JumpThreading/select.ll
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

Exit Code: 1

Command Output (stderr):
------------------------

/usr/local/google3/cmtice/new-llvm-project/llvm/test/Transforms/JumpThreading/select.ll:4:16: error: CHECK-LABEL: expected string not found in input
; CHECK-LABEL: ---- Branch Probability Info : unfold1 ----

  ^

<stdin>:1:1: note: scanning from here
opt: Unknown command line argument '-debug-only=branch-prob'. Try: '/usr/local/google3/cmtice/new-llvm-project/build-opt/bin/opt --help'
^
<stdin>:1:43: note: possible intended match here
opt: Unknown command line argument '-debug-only=branch-prob'. Try: '/usr/local/google3/cmtice/new-llvm-project/build-opt/bin/opt --help'

  ^

Input file: <stdin>
Check file: /usr/local/google3/cmtice/new-llvm-project/llvm/test/Transforms/JumpThreading/select.ll

-dump-input=help explains the following input dump.

Input was:
<<<<<<

  1: opt: Unknown command line argument '-debug-only=branch-prob'. Try: '/usr/local/google3/cmtice/new-llvm-project/build-opt/bin/opt --help' 

label:4'0     X~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ error: no match found
label:4'1                                               ?                                                                                               possible intended match

  2: opt: Did you mean '--debug-pass=branch-prob'? 

label:4'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

>>>>>> 



-

********************

********************

Failed Tests (1):

  LLVM :: Transforms/JumpThreading/select.ll

Testing Time: 0.52s

  Failed: 1

$


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138132/new/

https://reviews.llvm.org/D138132