[PATCH] D110450: [LLD] Remove global state in lld/COFF

Alexandre Ganea via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 9 20:42:47 PST 2023


aganea added inline comments.


================
Comment at: lld/COFF/COFFLinkerContext.cpp:41
+  FakeSection ltoDataSection(llvm::COFF::IMAGE_SCN_CNT_INITIALIZED_DATA);
+  ltoTextSectionChunk = make<FakeSectionChunk>(&ltoTextSection.section);
+  ltoDataSectionChunk = make<FakeSectionChunk>(&ltoDataSection.section);
----------------
@mstorsjo These two structs were keeping a dangling pointer, as the `FakeSection`s above went out of scope.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110450/new/

https://reviews.llvm.org/D110450



More information about the llvm-commits mailing list