[PATCH] D139582: [GVN] Improve PRE on load instructions

[Douglas Yung via Phabricator via llvm-commits]

dyung added a comment.

In D139582#4038393 <https://reviews.llvm.org/D139582#4038393>, @Carrot wrote:

> @dyung @chapuni thank you for the report, I have reverted it.
> How did you investigate it ? I try to reproduce it according to https://github.com/google/sanitizers/wiki/SanitizerBotReproduceBuild, but always got following error
>
>   ...
>   + BUILDBOT_MONO_REPO_PATH=
>   + BUILDBOT_REVISION=llvmorg-
>   + buildbot_update
>   + echo @@@BUILD_STEP update llvmorg-@@@
>   @@@BUILD_STEP update llvmorg-@@@
>   + [[ -d '' ]]
>   + local DEPTH=100
>   + [[ -d llvm-project ]]
>   + cd llvm-project
>   + git fetch origin
>   + git clean -fd
>   + local REV=llvmorg-
>   + git checkout -f llvmorg-
>   error: pathspec 'llvmorg-' did not match any file(s) known to git
>   + git status
>   On branch main
>   
>   No commits yet
>   
>   nothing to commit (create/copy files and use "git add" to track)
>   + git rev-list --pretty --max-count=1 HEAD
>   fatal: ambiguous argument 'HEAD': unknown revision or path not in the working tree.
>   Use '--' to separate paths from revisions, like this:
>   'git <command> [<revision>...] -- [<file>...]'
>   + build_exception
>   + echo
>   
>   + echo 'How to reproduce locally: https://github.com/google/sanitizers/wiki/SanitizerBotReproduceBuild'
>   How to reproduce locally: https://github.com/google/sanitizers/wiki/SanitizerBotReproduceBuild
>   + echo
>   ...

I can't speak for the sanitizer bot, but for llvm-clang-x865_64-gcc-ubuntu you should be able to reproduce some of the failures by running:

- cmake ../llvm-project/llvm -DCMAKE_C_COMPILER=gcc -DCMAKE_CXX_COMPILER=g++ -DCMAKE_BUILD_TYPE=Release -DCLANG_ENABLE_CLANGD=OFF -DLLVM_BUILD_RUNTIME=ON -DLLVM_BUILD_TESTS=ON -DLLVM_ENABLE_ASSERTIONS=ON -DLLVM_INCLUDE_EXAMPLES=OFF '-DLLVM_LIT_ARGS=--verbose -j48' -DLLVM_USE_LINKER=gold '-DLLVM_ENABLE_PROJECTS=compiler-rt;clang;lld;cross-project-tests;llvm;clang-tools-extra' -GNinja
- ninja check-fuzzer




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139582/new/

https://reviews.llvm.org/D139582