[PATCH] D140457: [BOLT] Process fragment siblings in lite mode, keep lite mode on

Maksim Panchenko via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 9 18:38:56 PST 2023


maksfb added a comment.

What do you think about preliminary matching fragments while reading the symbol table for non-stripped binaries? It's almost exactly what you are doing in this diff, right?



================
Comment at: bolt/test/X86/fragment-lite-reverse.s:47
+
+  .globl foo.cold.1
+  .type foo.cold.1, %function
----------------
How is `foo` different from `main` for the purpose of this test?

>From what I've seen, cold fragments typically have local visibility (but we shouldn't rely on it), while main fragments could be of any type.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140457/new/

https://reviews.llvm.org/D140457



More information about the llvm-commits mailing list