[PATCH] D141327: [llvm][ADT] Add deduction guides for `MutableArrayRef`
Joe Loser via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jan 9 17:57:44 PST 2023
jloser added a comment.
In D141327#4038061 <https://reviews.llvm.org/D141327#4038061>, @dblaikie wrote:
> Test coverage might be nice - some static asserts about the type that's deduced is probably sufficient (`static_assert(std::is_same_v<MutableArrayRef<int, 3>, MutableArrayRef(std::declval<int[3]>())>)` or something like that for each deduction guide)?
I added both compile time tests for each of the deduction guides and runtime tests similar to that of `makeMutableArrayRef` test above. Let me know what you think. Thanks for the nudge on testing.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D141327/new/
https://reviews.llvm.org/D141327
More information about the llvm-commits
mailing list