[PATCH] D141337: [SPIR-V] Fix translation of aggregate undef operands

Michal Paszkowski via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 9 17:24:59 PST 2023


mpaszkowski created this revision.
mpaszkowski added reviewers: iliya-diyachkov, konrad.trifunovic, andreytr, zuban32, rengolin, arsenm, MaskRay.
Herald added subscribers: ThomasRaoux, hiraditya.
Herald added a project: All.
mpaszkowski requested review of this revision.
Herald added subscribers: llvm-commits, wdng.
Herald added a project: LLVM.

This patch:

- Extends the preprocessing of constant aggregates for undefs. Such operands are replaced with a call to //llvm.spv.const.composite//.
- Adds a test undef-composite-store.ll demonstrating the issue.
- Adjusts and fixes formatting of two other tests.

More about this patch can be found here <https://github.com/KhronosGroup/LLVM-SPIRV-Backend/pull/245>.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D141337

Files:
  llvm/lib/Target/SPIRV/SPIRVEmitIntrinsics.cpp
  llvm/test/CodeGen/SPIRV/instructions/call-complex-function.ll
  llvm/test/CodeGen/SPIRV/instructions/nested-composites.ll
  llvm/test/CodeGen/SPIRV/instructions/undef-composite-store.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D141337.487609.patch
Type: text/x-patch
Size: 9592 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230110/c4f8fa75/attachment.bin>


More information about the llvm-commits mailing list