[PATCH] D140280: [llvm] Fix APInt to work in C++20 mode

Joe Loser via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 9 15:44:03 PST 2023


jloser added a comment.

In D140280#4005992 <https://reviews.llvm.org/D140280#4005992>, @dblaikie wrote:

> Is there a way to write this in a more portable fashion?
>
> (if the uint64_t on nthe RHS versions were non-members, would that help?)

Sorry for the delay here — I've been on vacation from the holidays.  I'll play with it some more to get this to be more portable as I'm not too thrilled with the solution in its current form.  IIRC, making the member comparison `operator==(uint64_t)` a non-member didn't help things.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140280/new/

https://reviews.llvm.org/D140280



More information about the llvm-commits mailing list