[PATCH] D133925: [DebugInfo] Fix: Variables that have no non-empty values being emitted when they have a DBG_VALUE_LIST

[David Blaikie via Phabricator via llvm-commits]

dblaikie added a comment.

Hmm - shouldn't we still see `localh` emitted, but without a `DW_AT_location` - dropping the variable entirely seems incorrect? I guess just for this test case that happens because the variable isn't listed in the `DISubprogram`'s `variables` list?

Though internally at Google we're seeing an increase in the `llvm-dwarfdump --statistics` result for `#params with binary locations/#params` and `#local vars with binary locations/#local vars` - which suggests maybe this change is having the effect of dropping some variables entirely, leading to an apparent increase in these statistics?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133925/new/

https://reviews.llvm.org/D133925