[PATCH] D141074: [X86] Avoid converting 64-bit integers to floating point using x87 on Windows

Mon Jan 9 14:55:36 PST 2023

icedrocket added a comment.

In D141074#4037794 <https://reviews.llvm.org/D141074#4037794>, @lebedev.ri wrote:

> Does the libcall not produce the right answer? That sounds like a bug.
> I think this patch should *just* be about falling back to the libcall.

If SSE2 is available, we only need to use library calls to convert between 64-bit integers and floating point. However, if only x87 is available, precision issues are unavoidable. In this case, it might be better to just use the x87 implementation and print a warning.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141074/new/

https://reviews.llvm.org/D141074