[PATCH] D141317: [SDAG] Introduce a common MEMBARRIER node [nfc]

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 9 14:30:30 PST 2023


reames added inline comments.


================
Comment at: llvm/lib/Target/X86/X86InstrCompiler.td:687
                      "#MEMBARRIER",
-                     [(X86MemBarrier)]>, Sched<[WriteLoad]>;
+                     [(membarrier)]>, Sched<[WriteLoad]>;
 
----------------
arsenm wrote:
> Why not go one step further and have a generic barrier machine instr?
We may.  One step at a time.  :)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141317/new/

https://reviews.llvm.org/D141317



More information about the llvm-commits mailing list